* [patch] mac80211: use kfree_skb() instead of kfree()
@ 2011-11-15 6:33 Dan Carpenter
2011-11-15 6:38 ` Arik Nemtsov
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-15 6:33 UTC (permalink / raw)
To: Johannes Berg, Arik Nemtsov
Cc: John W. Linville, linux-wireless, kernel-janitors
sk_buff structs should be freed using kfree_skb().
This was introduced recently in 029458212 "mac80211: Save probe
response data for bss".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 12a6d4b..b34ca0c 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -474,7 +474,7 @@ static void ieee80211_do_stop(struct ieee80211_sub_if_data *sdata,
RCU_INIT_POINTER(sdata->u.ap.probe_resp, NULL);
synchronize_rcu();
kfree(old_beacon);
- kfree(old_probe_resp);
+ kfree_skb(old_probe_resp);
/* down all dependent devices, that is VLANs */
list_for_each_entry_safe(vlan, tmpsdata, &sdata->u.ap.vlans,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] mac80211: use kfree_skb() instead of kfree()
2011-11-15 6:33 [patch] mac80211: use kfree_skb() instead of kfree() Dan Carpenter
@ 2011-11-15 6:38 ` Arik Nemtsov
0 siblings, 0 replies; 2+ messages in thread
From: Arik Nemtsov @ 2011-11-15 6:38 UTC (permalink / raw)
To: Dan Carpenter
Cc: Johannes Berg, John W. Linville, linux-wireless, kernel-janitors
On Tue, Nov 15, 2011 at 08:33, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> sk_buff structs should be freed using kfree_skb().
>
> This was introduced recently in 029458212 "mac80211: Save probe
> response data for bss".
>
Thanks for this one. I'm getting careless lately.. :)
Arik
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-15 6:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-15 6:33 [patch] mac80211: use kfree_skb() instead of kfree() Dan Carpenter
2011-11-15 6:38 ` Arik Nemtsov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox