* [patch -next] [media] Staging: as102: pass device to dev_err()
@ 2011-11-16 8:25 Dan Carpenter
2011-11-16 19:22 ` Sylwester Nawrocki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-16 8:25 UTC (permalink / raw)
To: kernel-janitors
We'd oops if we hit this dev_err() and also gcc complains:
drivers/staging/media/as102/as102_drv.c: In function ‘as102_dvb_register’:
drivers/staging/media/as102/as102_drv.c:223:3:
warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c
index b8adfd2..beacb2c 100644
--- a/drivers/staging/media/as102/as102_drv.c
+++ b/drivers/staging/media/as102/as102_drv.c
@@ -220,7 +220,7 @@ int as102_dvb_register(struct as102_dev_t *as102_dev)
ret = dvb_dmx_init(&as102_dev->dvb_dmx);
if (ret < 0) {
- dev_err("%s: dvb_dmx_init() failed: %d\n", __func__, ret);
+ dev_err(dev, "%s: dvb_dmx_init() failed: %d\n", __func__, ret);
goto edmxinit;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch -next] [media] Staging: as102: pass device to dev_err()
2011-11-16 8:25 [patch -next] [media] Staging: as102: pass device to dev_err() Dan Carpenter
@ 2011-11-16 19:22 ` Sylwester Nawrocki
0 siblings, 0 replies; 2+ messages in thread
From: Sylwester Nawrocki @ 2011-11-16 19:22 UTC (permalink / raw)
To: kernel-janitors
Hi,
On 11/16/2011 09:25 AM, Dan Carpenter wrote:
> We'd oops if we hit this dev_err() and also gcc complains:
>
> drivers/staging/media/as102/as102_drv.c: In function ‘as102_dvb_register’:
> drivers/staging/media/as102/as102_drv.c:223:3:
> warning: passing argument 1 of ‘dev_err’ from incompatible pointer type [enabled by default]
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/media/as102/as102_drv.c b/drivers/staging/media/as102/as102_drv.c
> index b8adfd2..beacb2c 100644
> --- a/drivers/staging/media/as102/as102_drv.c
> +++ b/drivers/staging/media/as102/as102_drv.c
> @@ -220,7 +220,7 @@ int as102_dvb_register(struct as102_dev_t *as102_dev)
>
> ret = dvb_dmx_init(&as102_dev->dvb_dmx);
> if (ret< 0) {
> - dev_err("%s: dvb_dmx_init() failed: %d\n", __func__, ret);
> + dev_err(dev, "%s: dvb_dmx_init() failed: %d\n", __func__, ret);
> goto edmxinit;
> }
Thanks for the patch. However I have addressed the issue already and similar patch
is sitting in the patchwork system, waiting for merging. Please see
http://patchwork.linuxtv.org/patch/8355/
--
Regards,
Sylwester
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-16 19:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-16 8:25 [patch -next] [media] Staging: as102: pass device to dev_err() Dan Carpenter
2011-11-16 19:22 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox