From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dan Carpenter <error27@gmail.com>
Cc: Jing Huang <huangj@brocade.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
"open list:BROCADE BFA FC SC..." <linux-scsi@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] [SCSI] bfa: dereferencing freed memory in bfad_im_probe()
Date: Fri, 18 Nov 2011 13:55:29 +0000 [thread overview]
Message-ID: <20111118135528.GI29436@mwanda> (raw)
In-Reply-To: <20110729085306.GH3752@shale.localdomain>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Fri, Jul 29, 2011 at 11:53:06AM +0300, Dan Carpenter wrote:
> If bfad_thread_workq(bfad) was not BFA_STATUS_OK then we freed "im"
> and then dereferenced it.
>
> I did a little clean up because it seemed nicer to return directly
> instead of doing a superfluous goto. I looked at other functions in
> this file and it seems like returning directly is standard.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Ping.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2011-11-18 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-29 8:53 [patch] [SCSI] bfa: dereferencing freed memory in bfad_im_probe() Dan Carpenter
2011-11-18 13:55 ` Dan Carpenter [this message]
2012-02-29 12:59 ` [resend] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111118135528.GI29436@mwanda \
--to=dan.carpenter@oracle.com \
--cc=JBottomley@parallels.com \
--cc=error27@gmail.com \
--cc=huangj@brocade.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox