* [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate()
@ 2011-11-20 21:04 Dan Carpenter
2011-11-21 8:52 ` Stanislaw Gruszka
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-11-20 21:04 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: John W. Linville, linux-wireless, kernel-janitors
We use "rate_index" like this:
rate = iwl3945_rates[rate_index].plcp;
The iwl3945_rates[] array has IWL_RATE_COUNT_3945 elements so the
limit here is off by one.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/iwlegacy/iwl-3945.c b/drivers/net/wireless/iwlegacy/iwl-3945.c
index f7c0a74..1627048 100644
--- a/drivers/net/wireless/iwlegacy/iwl-3945.c
+++ b/drivers/net/wireless/iwlegacy/iwl-3945.c
@@ -676,7 +676,7 @@ void iwl3945_hw_build_tx_cmd_rate(struct iwl_priv *priv,
int sta_id, int tx_id)
{
u16 hw_value = ieee80211_get_tx_rate(priv->hw, info)->hw_value;
- u16 rate_index = min(hw_value & 0xffff, IWL_RATE_COUNT_3945);
+ u16 rate_index = min(hw_value & 0xffff, IWL_RATE_COUNT_3945 - 1);
u16 rate_mask;
int rate;
u8 rts_retry_limit;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate()
2011-11-20 21:04 [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate() Dan Carpenter
@ 2011-11-21 8:52 ` Stanislaw Gruszka
0 siblings, 0 replies; 2+ messages in thread
From: Stanislaw Gruszka @ 2011-11-21 8:52 UTC (permalink / raw)
To: Dan Carpenter; +Cc: John W. Linville, linux-wireless, kernel-janitors
On Mon, Nov 21, 2011 at 12:04:00AM +0300, Dan Carpenter wrote:
> We use "rate_index" like this:
> rate = iwl3945_rates[rate_index].plcp;
> The iwl3945_rates[] array has IWL_RATE_COUNT_3945 elements so the
> limit here is off by one.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks Dan. I queued patch into iwlegacy github tree on top
of my current changes, otherwise there would be problems with
merging.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-21 8:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-20 21:04 [patch] iwlegacy: off by one in iwl3945_hw_build_tx_cmd_rate() Dan Carpenter
2011-11-21 8:52 ` Stanislaw Gruszka
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox