From: Al Viro <viro@ZenIV.linux.org.uk>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Sjur Braendeland <sjur.brandeland@stericsson.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] caif: fix endian conversion in cffrml_transmit()
Date: Mon, 21 Nov 2011 06:33:56 +0000 [thread overview]
Message-ID: <20111121063356.GH2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20111121061722.GD7354@elgon.mountain>
On Mon, Nov 21, 2011 at 09:17:22AM +0300, Dan Carpenter wrote:
> The "tmp" variable here is used to store the result of cpu_to_le16()
> so it should be a u16 instead of an int. We want the high bits set
> and the current code works on little endian systems but not on big
> endian systems.
Charming... On b-e we end up feeding zeroes instead of the value we want.
However, that u16 clearly ought to be __le16 - it's there for purpose.
next prev parent reply other threads:[~2011-11-21 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 6:17 [patch] caif: fix endian conversion in cffrml_transmit() Dan Carpenter
2011-11-21 6:33 ` Al Viro [this message]
2011-11-21 19:50 ` [patch v2] " Dan Carpenter
2011-11-21 21:20 ` Sjur Brændeland
2011-11-21 21:46 ` David Miller
2011-11-21 14:36 ` [patch] " Sjur BRENDELAND
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111121063356.GH2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sjur.brandeland@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox