* [patch] wimax/i2400m: remove an unused variable
@ 2011-12-16 10:22 Dan Carpenter
2011-12-16 22:09 ` Perez-Gonzalez, Inaky
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2011-12-16 10:22 UTC (permalink / raw)
To: Inaky Perez-Gonzalez; +Cc: linux-wimax, wimax, netdev, kernel-janitors
"result" isn't used. We ignore errors here because there is not much we
can do about them.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wimax/i2400m/usb-tx.c b/drivers/net/wimax/i2400m/usb-tx.c
index ac357ac..99ef81b 100644
--- a/drivers/net/wimax/i2400m/usb-tx.c
+++ b/drivers/net/wimax/i2400m/usb-tx.c
@@ -177,7 +177,6 @@ retry:
static
int i2400mu_txd(void *_i2400mu)
{
- int result = 0;
struct i2400mu *i2400mu = _i2400mu;
struct i2400m *i2400m = &i2400mu->i2400m;
struct device *dev = &i2400mu->usb_iface->dev;
@@ -208,16 +207,14 @@ int i2400mu_txd(void *_i2400mu)
/* Yeah, we ignore errors ... not much we can do */
i2400mu_tx(i2400mu, tx_msg, tx_msg_size);
i2400m_tx_msg_sent(i2400m); /* ack it, advance the FIFO */
- if (result < 0)
- break;
}
spin_lock_irqsave(&i2400m->tx_lock, flags);
i2400mu->tx_kthread = NULL;
spin_unlock_irqrestore(&i2400m->tx_lock, flags);
- d_fnend(4, dev, "(i2400mu %p) = %d\n", i2400mu, result);
- return result;
+ d_fnend(4, dev, "(i2400mu %p)\n", i2400mu);
+ return 0;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [patch] wimax/i2400m: remove an unused variable
2011-12-16 10:22 [patch] wimax/i2400m: remove an unused variable Dan Carpenter
@ 2011-12-16 22:09 ` Perez-Gonzalez, Inaky
2011-12-17 0:07 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Perez-Gonzalez, Inaky @ 2011-12-16 22:09 UTC (permalink / raw)
To: Dan Carpenter
Cc: linux-wimax, wimax@linuxwimax.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
> Subject: [patch] wimax/i2400m: remove an unused variable
>
> "result" isn't used. We ignore errors here because there is not much
> we can do about them.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This is an ACK or a NAK depending on if you want to keep the reporting
with debug enabled or not. It is not so difficult to add back if needed,
so I tend to ACK.
Thank you,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] wimax/i2400m: remove an unused variable
2011-12-16 22:09 ` Perez-Gonzalez, Inaky
@ 2011-12-17 0:07 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2011-12-17 0:07 UTC (permalink / raw)
To: inaky.perez-gonzalez
Cc: netdev, kernel-janitors, wimax, dan.carpenter, linux-wimax
From: "Perez-Gonzalez, Inaky" <inaky.perez-gonzalez@intel.com>
Date: Fri, 16 Dec 2011 22:09:29 +0000
>> Subject: [patch] wimax/i2400m: remove an unused variable
>>
>> "result" isn't used. We ignore errors here because there is not much
>> we can do about them.
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> This is an ACK or a NAK depending on if you want to keep the reporting
> with debug enabled or not. It is not so difficult to add back if needed,
> so I tend to ACK.
And FWIW I applied this to net-next already.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-17 0:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 10:22 [patch] wimax/i2400m: remove an unused variable Dan Carpenter
2011-12-16 22:09 ` Perez-Gonzalez, Inaky
2011-12-17 0:07 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox