* [patch] usb: gadget: mv_udc: remove unneeded NULL check
@ 2012-01-04 7:20 Dan Carpenter
2012-01-24 9:36 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-04 7:20 UTC (permalink / raw)
To: kernel-janitors
We've dereferenced req already, and we checked for bogus parameters at
the start of the function.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/gadget/mv_udc_core.c b/drivers/usb/gadget/mv_udc_core.c
index f97e737..8dd398b 100644
--- a/drivers/usb/gadget/mv_udc_core.c
+++ b/drivers/usb/gadget/mv_udc_core.c
@@ -771,8 +771,7 @@ mv_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
udc->ep0_state = DATA_STATE_XMIT;
/* irq handler advances the queue */
- if (req != NULL)
- list_add_tail(&req->queue, &ep->queue);
+ list_add_tail(&req->queue, &ep->queue);
spin_unlock_irqrestore(&udc->lock, flags);
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] usb: gadget: mv_udc: remove unneeded NULL check
2012-01-04 7:20 [patch] usb: gadget: mv_udc: remove unneeded NULL check Dan Carpenter
@ 2012-01-24 9:36 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2012-01-24 9:36 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 264 bytes --]
On Wed, Jan 04, 2012 at 10:20:09AM +0300, Dan Carpenter wrote:
> We've dereferenced req already, and we checked for bogus parameters at
> the start of the function.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
applied, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-24 9:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04 7:20 [patch] usb: gadget: mv_udc: remove unneeded NULL check Dan Carpenter
2012-01-24 9:36 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox