public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] gma500: silence gcc warnings in mid_get_vbt_data()
@ 2012-01-04  7:26 Dan Carpenter
  2012-01-04 11:48 ` Alan Cox
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-04  7:26 UTC (permalink / raw)
  To: David Airlie
  Cc: Greg Kroah-Hartman, kernel-janitors, dri-devel, Paul Gortmaker,
	Dave Airlie, Alan Cox

Add a cast here to silence a Gcc warning.
drivers/gpu/drm/gma500/mid_bios.c:214:28: warning:
  cast from pointer to integer of different size [-Wpointer-to-int-cast]

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
Compile tested only.

diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c
index 55fee10..5eee9ad 100644
--- a/drivers/gpu/drm/gma500/mid_bios.c
+++ b/drivers/gpu/drm/gma500/mid_bios.c
@@ -202,7 +202,7 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
 		/*so, some values have changed location*/
 		new_size = vbt->checksum; /*checksum contains lo size byte*/
 		/*LSB of oaktrail_gct contains hi size byte*/
-		new_size |= ((0xff & (unsigned int)vbt->oaktrail_gct)) << 8;
+		new_size |= ((0xff & (unsigned int)(long)vbt->oaktrail_gct)) << 8;
 
 		vbt->checksum = vbt->size; /*size contains the checksum*/
 		if (new_size > 0xff)
@@ -211,8 +211,8 @@ static void mid_get_vbt_data(struct drm_psb_private *dev_priv)
 			vbt->size = new_size;
 
 		/* number of descriptors defined in the GCT */
-		number_desc = ((0xff00 & (unsigned int)vbt->oaktrail_gct)) >> 8;
-		bpi = ((0xff0000 & (unsigned int)vbt->oaktrail_gct)) >> 16;
+		number_desc = ((0xff00 & (unsigned int)(long)vbt->oaktrail_gct)) >> 8;
+		bpi = ((0xff0000 & (unsigned int)(long)vbt->oaktrail_gct)) >> 16;
 		vbt->oaktrail_gct = ioremap(addr + GCT_R10_HEADER_SIZE,
 				GCT_R10_DISPLAY_DESC_SIZE * number_desc);
 		pGCT = vbt->oaktrail_gct;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [patch] gma500: silence gcc warnings in mid_get_vbt_data()
  2012-01-04  7:26 [patch] gma500: silence gcc warnings in mid_get_vbt_data() Dan Carpenter
@ 2012-01-04 11:48 ` Alan Cox
  0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2012-01-04 11:48 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Greg Kroah-Hartman, kernel-janitors, dri-devel, Paul Gortmaker,
	Dave Airlie

On Wed, 4 Jan 2012 10:26:10 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> Add a cast here to silence a Gcc warning.
> drivers/gpu/drm/gma500/mid_bios.c:214:28: warning:
>   cast from pointer to integer of different size
> [-Wpointer-to-int-cast]
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> Compile tested only.

It's actually a non-bug (no 64bit boxes and we always take from within
the low 32bits). I guess gcc would have to extremely smart to figure
that out though.

Acked-by: Alan Cox <alan@linux.intel.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-04 11:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-04  7:26 [patch] gma500: silence gcc warnings in mid_get_vbt_data() Dan Carpenter
2012-01-04 11:48 ` Alan Cox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox