Re: [PATCH 15/16] Staging: quickstart: Add QS_INFO and QS_ERR macros for logs

[Dan Carpenter <dan.carpenter@oracle.com>]

[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]

On Mon, Jan 09, 2012 at 11:23:34PM +0100, Szymon Janc wrote:
> Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> ---
>  drivers/staging/quickstart/quickstart.c |   17 +++++++++--------
>  1 files changed, 9 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> index 51a6d0c..c757ef6 100644
> --- a/drivers/staging/quickstart/quickstart.c
> +++ b/drivers/staging/quickstart/quickstart.c
> @@ -44,6 +44,9 @@ MODULE_LICENSE("GPL");
>  #define QUICKSTART_PF_DRIVER_NAME	"quickstart"
>  #define QUICKSTART_PF_DEVICE_NAME	"quickstart"
>  
> +#define QS_INFO(fmt, arg...)	printk(KERN_INFO "quickstart: " fmt "\n", ##arg)
> +#define QS_ERR(fmt, arg...)	printk(KERN_ERR "quickstart: " fmt "\n", ##arg)
> +

No.  Don't do this.  You can do same thing with pr_err() so you
don't need to create your own macros.  Just add this to the front:

#define pr_fmt(fmt) "quickstart: " fmt

We already have a million standard ways of printing stuff, we don't
need a million and two.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]