From: Szymon Janc <szymon@janc.net.pl>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 12/16] Staging: quickstart: Use list.h API for buttons list
Date: Wed, 11 Jan 2012 17:47:50 +0000 [thread overview]
Message-ID: <201201111847.50660.szymon@janc.net.pl> (raw)
In-Reply-To: <1326147815-11451-13-git-send-email-szymon@janc.net.pl>
Hi,
> > + list_for_each_entry(b, &buttons, list) {
> > + count += snprintf(buf + count, PAGE_SIZE - count, "%d\t%s\n",
> > + b->id, b->name);
> > +
> > + if (count = PAGE_SIZE)
>
> snprintf() returns the number of bytes which would have been used if
> there were space so this test should be >= instead of =.
>
> > + break;
> >
> > }
Yes, I'll fix that.
Thx
--
Szymon K. Janc
szymon@janc.net.pl
prev parent reply other threads:[~2012-01-11 17:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-09 22:23 [PATCH 12/16] Staging: quickstart: Use list.h API for buttons list Szymon Janc
2012-01-11 11:47 ` Dan Carpenter
2012-01-11 17:47 ` Szymon Janc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201111847.50660.szymon@janc.net.pl \
--to=szymon@janc.net.pl \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox