* [patch] drm/nouveau/dp: nouveau_dp_link_train() returns bool
@ 2012-01-15 11:31 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-01-15 11:31 UTC (permalink / raw)
To: David Airlie; +Cc: kernel-janitors, Ben Skeggs, dri-devel
The caller doesn't check the return value, but this function returns a
bool so static checkers complain when we return a negative error code.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/nouveau/nouveau_dp.c b/drivers/gpu/drm/nouveau/nouveau_dp.c
index 9b93b70..dcffd13 100644
--- a/drivers/gpu/drm/nouveau/nouveau_dp.c
+++ b/drivers/gpu/drm/nouveau/nouveau_dp.c
@@ -573,7 +573,7 @@ nouveau_dp_link_train(struct drm_encoder *encoder, u32 datarate)
dp.table = nouveau_dp_bios_data(dev, nv_encoder->dcb, &dp.entry);
if (!dp.table)
- return -EINVAL;
+ return false;
dp.dcb = nv_encoder->dcb;
dp.crtc = nv_crtc->index;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-15 11:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-15 11:31 [patch] drm/nouveau/dp: nouveau_dp_link_train() returns bool Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox