public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] target: handle empty string writes in sysfs
Date: Tue, 24 Jan 2012 08:40:36 +0000	[thread overview]
Message-ID: <20120124084036.GB29097@elgon.mountain> (raw)

These are root only and we're not likely to hit the problem in practise,
but it makes a the static checkers happy.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c
index 0955bb8..9b86330 100644
--- a/drivers/target/target_core_configfs.c
+++ b/drivers/target/target_core_configfs.c
@@ -1707,6 +1707,8 @@ static ssize_t target_core_store_dev_alias(
 	se_dev->su_dev_flags |= SDF_USING_ALIAS;
 	read_bytes = snprintf(&se_dev->se_dev_alias[0], SE_DEV_ALIAS_LEN,
 			"%s", page);
+	if (read_bytes = 0)
+		return -EINVAL;
 
 	if (se_dev->se_dev_alias[read_bytes - 1] = '\n')
 		se_dev->se_dev_alias[read_bytes - 1] = '\0';
@@ -1756,6 +1758,8 @@ static ssize_t target_core_store_dev_udev_path(
 	se_dev->su_dev_flags |= SDF_USING_UDEV_PATH;
 	read_bytes = snprintf(&se_dev->se_dev_udev_path[0], SE_UDEV_PATH_LEN,
 			"%s", page);
+	if (read_bytes = 0)
+		return -EINVAL;
 
 	if (se_dev->se_dev_udev_path[read_bytes - 1] = '\n')
 		se_dev->se_dev_udev_path[read_bytes - 1] = '\0';

             reply	other threads:[~2012-01-24  8:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-24  8:40 Dan Carpenter [this message]
2012-01-24 10:55 ` [patch] target: handle empty string writes in sysfs walter harms
2012-01-26 12:19   ` Dan Carpenter
2012-01-27 12:50   ` [patch v2] " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120124084036.GB29097@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=target-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox