* [patch] intelfb: remove some dead code
@ 2012-01-27 12:45 Dan Carpenter
2012-01-27 12:55 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-01-27 12:45 UTC (permalink / raw)
To: linux-fbdev
The goto on the line before means the return is unreachable. The goto
also returns -ENOMEM so no changes are needed there.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index c6afa33..02fd226 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
ERR_MSG("Could not allocate cmap for intelfb_info.\n");
goto err_out_cmap;
- return -ENODEV;
}
dinfo = info->par;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] intelfb: remove some dead code
2012-01-27 12:45 [patch] intelfb: remove some dead code Dan Carpenter
@ 2012-01-27 12:55 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-01-27 12:55 UTC (permalink / raw)
To: linux-fbdev
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
On Fri, Jan 27, 2012 at 03:45:36PM +0300, Dan Carpenter wrote:
> The goto on the line before means the return is unreachable. The goto
> also returns -ENOMEM so no changes are needed there.
I meant ENODEV there. Let me resend this.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-27 12:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-27 12:45 [patch] intelfb: remove some dead code Dan Carpenter
2012-01-27 12:55 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).