From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] exofs: fix endian conversion in exofs_sync_fs()
Date: Sun, 29 Jan 2012 14:29:57 +0000 [thread overview]
Message-ID: <20120129142957.GF3356@mwanda> (raw)
In-Reply-To: <20111121144311.GA19025@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 896 bytes --]
On Sun, Jan 29, 2012 at 05:25:33PM +0300, Dan Carpenter wrote:
> On Mon, Nov 21, 2011 at 04:57:23PM -0800, Boaz Harrosh wrote:
> > On 11/21/2011 06:43 AM, Dan Carpenter wrote:
> > > fscb->s_numfiles is an __le64 field so we need to use cpu_to_le64()
> > > to get a little endian 64 bit on big endian systems.
> > >
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > > ---
> > > This is a static checker fix. Untested.
> > >
> >
> > Will apply. s_numfiles is never used but should be loaded
> > correctly regardless.
> >
>
> This is still the same in linux-next.
Also Sparse warns about the following potential stack overflows.
The kernel has an 8k stack and the upper limit on these array sizes
are not capped.
fs/exofs/super.c:562:51: error: bad constant expression
fs/exofs/super.c:563:38: error: bad constant expression
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-29 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 14:43 [patch] exofs: fix endian conversion in exofs_sync_fs() Dan Carpenter
2011-11-22 0:57 ` Boaz Harrosh
2012-01-29 14:25 ` Dan Carpenter
2012-01-29 14:29 ` Dan Carpenter [this message]
2012-01-30 13:45 ` Boaz Harrosh
2012-01-30 13:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120129142957.GF3356@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox