public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] exofs: fix endian conversion in exofs_sync_fs()
Date: Mon, 30 Jan 2012 13:58:58 +0000	[thread overview]
Message-ID: <20120130135858.GH3356@mwanda> (raw)
In-Reply-To: <20111121144311.GA19025@elgon.mountain>

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

On Mon, Jan 30, 2012 at 03:45:07PM +0200, Boaz Harrosh wrote:
> Do you mean this code:
> 	struct __alloc_ore_devs_and_exofs_devs {
> 		/* Twice bigger table: See exofs_init_comps() and comment at
> 		 * exofs_read_lookup_dev_table()
> 		 */
> =>		struct ore_dev *oreds[numdevs * 2 - 1];
> =>		struct exofs_dev eds[numdevs];
> 	} *aoded;
> 
> 
> If so than Sparse should be fixed. It is plain wrong. This complete
> structure is kmalloc(ed) two lines below.
> 

Oh yeah.  You are right.  I misread how that worked.

regards,
dan carpenter



[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2012-01-30 13:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-21 14:43 [patch] exofs: fix endian conversion in exofs_sync_fs() Dan Carpenter
2011-11-22  0:57 ` Boaz Harrosh
2012-01-29 14:25 ` Dan Carpenter
2012-01-29 14:29 ` Dan Carpenter
2012-01-30 13:45 ` Boaz Harrosh
2012-01-30 13:58 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120130135858.GH3356@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox