From: Felipe Balbi <balbi@ti.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] usb: dwc3: make dwc3_get_device_id() return the id
Date: Mon, 06 Feb 2012 08:17:08 +0000 [thread overview]
Message-ID: <20120206081707.GH15652@legolas.emea.dhcp.ti.com> (raw)
In-Reply-To: <20120204133714.GA4413@elgon.mountain>
[-- Attachment #1: Type: text/plain, Size: 769 bytes --]
On Mon, Feb 06, 2012 at 09:09:09AM +0100, walter harms wrote:
>
>
> Am 06.02.2012 07:44, schrieb Felipe Balbi:
> > On Sat, Feb 04, 2012 at 04:37:14PM +0300, Dan Carpenter wrote:
> >> We always return zero instead of the id we found.
> >>
> >> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Applied, thanks
> >
> >> ---
> >> I don't have this hardware so it's not tested.
> >
> > This one is so obvious that I can't even believe we haven't seen that
> > before, thanks ;-)
> >
>
> i was wondering why the driver worked at all, do you realy need that ?
as of now we don't have usecases for that. But since it can work on
PCIe, I was thinking of building an automated testmachine with two of
those devices ;-)
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-06 8:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 13:37 [patch] usb: dwc3: make dwc3_get_device_id() return the id Dan Carpenter
2012-02-06 6:44 ` Felipe Balbi
2012-02-06 8:09 ` walter harms
2012-02-06 8:17 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206081707.GH15652@legolas.emea.dhcp.ti.com \
--to=balbi@ti.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox