[PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Szymon Janc]

Signed-off-by: Szymon Janc <szymon@janc.net.pl>
---
 drivers/staging/quickstart/quickstart.c |   18 +++++++++---------
 1 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
index d03b89d..adce56b 100644
--- a/drivers/staging/quickstart/quickstart.c
+++ b/drivers/staging/quickstart/quickstart.c
@@ -92,19 +92,19 @@ static struct acpi_driver quickstart_acpi_driver = {
 struct input_dev *quickstart_input;
 
 /* Platform driver structs */
-static ssize_t buttons_show(struct device *dev,
+static ssize_t quickstart_buttons_show(struct device *dev,
 					struct device_attribute *attr,
 					char *buf);
-static ssize_t pressed_button_show(struct device *dev,
+static ssize_t quickstart_pressed_button_show(struct device *dev,
 					struct device_attribute *attr,
 					char *buf);
-static ssize_t pressed_button_store(struct device *dev,
+static ssize_t quickstart_pressed_button_store(struct device *dev,
 					struct device_attribute *attr,
 					 const char *buf,
 					 size_t count);
-static DEVICE_ATTR(pressed_button, 0666, pressed_button_show,
-					 pressed_button_store);
-static DEVICE_ATTR(buttons, 0444, buttons_show, NULL);
+static DEVICE_ATTR(pressed_button, 0666, quickstart_pressed_button_show,
+					 quickstart_pressed_button_store);
+static DEVICE_ATTR(buttons, 0444, quickstart_buttons_show, NULL);
 static struct platform_device *pf_device;
 static struct platform_driver pf_driver = {
 	.driver = {
@@ -114,7 +114,7 @@ static struct platform_driver pf_driver = {
 };
 
 /* Platform driver functions */
-static ssize_t buttons_show(struct device *dev,
+static ssize_t quickstart_buttons_show(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
 {
@@ -136,7 +136,7 @@ static ssize_t buttons_show(struct device *dev,
 	return count;
 }
 
-static ssize_t pressed_button_show(struct device *dev,
+static ssize_t quickstart_pressed_button_show(struct device *dev,
 						struct device_attribute *attr,
 						char *buf)
 {
@@ -146,7 +146,7 @@ static ssize_t pressed_button_show(struct device *dev,
 }
 
 
-static ssize_t pressed_button_store(struct device *dev,
+static ssize_t quickstart_pressed_button_store(struct device *dev,
 						struct device_attribute *attr,
 						const char *buf, size_t count)
 {
-- 
1.7.8.3

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Greg KH]

On Wed, Jan 11, 2012 at 11:22:37PM +0100, Szymon Janc wrote:
> Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> ---
>  drivers/staging/quickstart/quickstart.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> index d03b89d..adce56b 100644
> --- a/drivers/staging/quickstart/quickstart.c
> +++ b/drivers/staging/quickstart/quickstart.c
> @@ -92,19 +92,19 @@ static struct acpi_driver quickstart_acpi_driver = {
>  struct input_dev *quickstart_input;
>  
>  /* Platform driver structs */
> -static ssize_t buttons_show(struct device *dev,
> +static ssize_t quickstart_buttons_show(struct device *dev,
>  					struct device_attribute *attr,
>  					char *buf);

I'll take this, but you do know there is no reason for this, as these
are static functions.  I'd recommend keeping them as short as possible,
but hey, it's not my code...

thanks,

greg k-h

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Ângelo Arrifano]

On Wed, 8 Feb 2012 17:16:11 -0800
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Jan 11, 2012 at 11:22:37PM +0100, Szymon Janc wrote:
> > Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> > ---
> >  drivers/staging/quickstart/quickstart.c |   18 +++++++++---------
> >  1 files changed, 9 insertions(+), 9 deletions(-)
> > 
> > diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> > index d03b89d..adce56b 100644
> > --- a/drivers/staging/quickstart/quickstart.c
> > +++ b/drivers/staging/quickstart/quickstart.c
> > @@ -92,19 +92,19 @@ static struct acpi_driver quickstart_acpi_driver = {
> >  struct input_dev *quickstart_input;
> >  
> >  /* Platform driver structs */
> > -static ssize_t buttons_show(struct device *dev,
> > +static ssize_t quickstart_buttons_show(struct device *dev,
> >  					struct device_attribute *attr,
> >  					char *buf);
> 
> I'll take this, but you do know there is no reason for this, as these
> are static functions.  I'd recommend keeping them as short as possible,
> but hey, it's not my code...
> 
> thanks,
> 
> greg k-h

I agree with Greg on this one. At the time I didn't prefix these
functions with the module name because I wanted to make them clear they
were different. The difference lies in the fact that those functions
are only used to implement the sysfs interface.

Regards,
-- 
Angelo Arrifano (miknix)
Gentoo Developer
http://www.gentoo.org/~miknix
http://www.arrifano.com

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Szymon Janc]

Hi,

> > I'll take this, but you do know there is no reason for this, as these
> > are static functions.  I'd recommend keeping them as short as possible,
> > but hey, it's not my code...
> > 
> > thanks,
> > 
> > greg k-h
> 
> I agree with Greg on this one. At the time I didn't prefix these
> functions with the module name because I wanted to make them clear they
> were different. The difference lies in the fact that those functions
> are only used to implement the sysfs interface.

Yeah, maybe you are right. I thought it was just an oversight. I can send a 
patch that will get orig names back if you prefer.


-- 
Szymon K. Janc
szymon@janc.net.pl

Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

[Ângelo Arrifano]

On Fri, 10 Feb 2012 19:58:23 +0100
Szymon Janc <szymon@janc.net.pl> wrote:

> Hi,
> 
> > > I'll take this, but you do know there is no reason for this, as these
> > > are static functions.  I'd recommend keeping them as short as possible,
> > > but hey, it's not my code...
> > > 
> > > thanks,
> > > 
> > > greg k-h
> > 
> > I agree with Greg on this one. At the time I didn't prefix these
> > functions with the module name because I wanted to make them clear they
> > were different. The difference lies in the fact that those functions
> > are only used to implement the sysfs interface.
> 
> Yeah, maybe you are right. I thought it was just an oversight. I can send a 
> patch that will get orig names back if you prefer.

Well, if the patch is already applied, then no need to revert, as Greg said
the relevant functions are static, so the patch ends up being just cosmetic. :)

Thanks for pushing this out of staging.
- Angelo
> 
> 
> -- 
> Szymon K. Janc
> szymon@janc.net.pl
>