Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_

Ângelo Arrifano
2012-02-09T13:19:07Z

On Wed, 8 Feb 2012 17:16:11 -0800
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Jan 11, 2012 at 11:22:37PM +0100, Szymon Janc wrote:
> > Signed-off-by: Szymon Janc <szymon@janc.net.pl>
> > ---
> > drivers/staging/quickstart/quickstart.c | 18 +++++++++---------
> > 1 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/staging/quickstart/quickstart.c b/drivers/staging/quickstart/quickstart.c
> > index d03b89d..adce56b 100644
> > --- a/drivers/staging/quickstart/quickstart.c
> > +++ b/drivers/staging/quickstart/quickstart.c
> > @@ -92,19 +92,19 @@ static struct acpi_driver quickstart_acpi_driver = {
> > struct input_dev *quickstart_input;
> >
> > /* Platform driver structs */
> > -static ssize_t buttons_show(struct device *dev,
> > +static ssize_t quickstart_buttons_show(struct device *dev,
> > struct device_attribute *attr,
> > char *buf);
>
> I'll take this, but you do know there is no reason for this, as these
> are static functions. I'd recommend keeping them as short as possible,
> but hey, it's not my code...
>
> thanks,
>
> greg k-h

I agree with Greg on this one. At the time I didn't prefix these
functions with the module name because I wanted to make them clear they
were different. The difference lies in the fact that those functions
are only used to implement the sysfs interface.

Regards,
--
Angelo Arrifano (miknix)
Gentoo Developer