public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 00/17] Some work on quickstart driver in staging
Date: Thu, 09 Feb 2012 01:17:39 +0000	[thread overview]
Message-ID: <20120209011739.GA17363@kroah.com> (raw)
In-Reply-To: <1326320574-11220-1-git-send-email-szymon@janc.net.pl>

On Wed, Jan 11, 2012 at 11:27:33PM +0100, Szymon Janc wrote:
> On Wednesday 11 January 2012 23:22:35 Szymon Janc wrote:
> > Changes since v1:
> >  - use pr_{err,info} instead of custom macros for logs
> >  - fixed quickstart_buttons_show issue pointed out by Dan
> >  - Use scnprintf in quickstart_pressed_button_show
> > 
> > Thx for comments.
> 
> Opps.  Please ignore
> [PATCH 15/16] Staging: quickstart: Add QS_INFO and QS_ERR macros for logs
> [PATCH 16/16] Staging: quickstart: Bump driver version to 1.04
> in this series...

Ok, I think I got the right ones, please check that I did.

Also, you just created the following build warning, please send me a
patch fixing it up:

drivers/staging/quickstart/quickstart.c: In function ‘quickstart_acpi_ghid’:
drivers/staging/quickstart/quickstart.c:212:5: warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument 3 has type ‘acpi_size’ [-Wformat]

thanks,

greg k-h

  parent reply	other threads:[~2012-02-09  1:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 22:22 [PATCH v2 00/17] Some work on quickstart driver in staging Szymon Janc
2012-01-11 22:27 ` Szymon Janc
2012-02-06 18:21 ` Szymon Janc
2012-02-06 21:32 ` Greg Kroah-Hartman
2012-02-09  1:17 ` Greg KH [this message]
2012-02-09 20:14 ` Szymon Janc
2012-02-09 20:23 ` Greg KH
2012-02-10  6:59 ` Dan Carpenter
2012-02-10 19:21 ` Szymon Janc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120209011739.GA17363@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox