Re: [patch] relay: prevent integer overflow in relay_open()

Dan Carpenter
2012-02-09T12:36:17Z

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

On Thu, Feb 09, 2012 at 12:55:52PM +0100, walter harms wrote:
> numerical this is ok, but ...
> maybe it is better to cap the chan->n_subbufs at a useful number ?

We considered this question already earlier in the thread.

> The user can still allocate an insane number of bytes.
> Restricting subbuf_size*n_subbufs seems more logical (otherwise is this a real problem ?)
>

Yes. It is a real problem.

regards,
dan carpenter

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]