From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 00/17] Some work on quickstart driver in staging
Date: Fri, 10 Feb 2012 06:59:52 +0000 [thread overview]
Message-ID: <20120210070103.GC4204@mwanda> (raw)
In-Reply-To: <1326320574-11220-1-git-send-email-szymon@janc.net.pl>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
On Thu, Feb 09, 2012 at 09:14:18PM +0100, Szymon Janc wrote:
> > Also, you just created the following build warning, please send me a
> > patch fixing it up:
> >
> > drivers/staging/quickstart/quickstart.c: In function
> > ‘quickstart_acpi_ghid’: drivers/staging/quickstart/quickstart.c:212:5:
> > warning: format ‘%u’ expects argument of type ‘unsigned int’, but argument
> > 3 has type ‘acpi_size’ [-Wformat]
>
> acpi_size is u32 or u64 depending on arch, is it ok to just cast it to
> unsigned int for printing?
I don't get this warning on linux-next so I haven't looked at the
code, but unsigned long would be more normal I think.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-02-10 6:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 22:22 [PATCH v2 00/17] Some work on quickstart driver in staging Szymon Janc
2012-01-11 22:27 ` Szymon Janc
2012-02-06 18:21 ` Szymon Janc
2012-02-06 21:32 ` Greg Kroah-Hartman
2012-02-09 1:17 ` Greg KH
2012-02-09 20:14 ` Szymon Janc
2012-02-09 20:23 ` Greg KH
2012-02-10 6:59 ` Dan Carpenter [this message]
2012-02-10 19:21 ` Szymon Janc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210070103.GC4204@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox