From: Szymon Janc <szymon@janc.net.pl>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_
Date: Fri, 10 Feb 2012 18:58:23 +0000 [thread overview]
Message-ID: <201202101958.23311.szymon@janc.net.pl> (raw)
In-Reply-To: <1326320574-11220-3-git-send-email-szymon@janc.net.pl>
Hi,
> > I'll take this, but you do know there is no reason for this, as these
> > are static functions. I'd recommend keeping them as short as possible,
> > but hey, it's not my code...
> >
> > thanks,
> >
> > greg k-h
>
> I agree with Greg on this one. At the time I didn't prefix these
> functions with the module name because I wanted to make them clear they
> were different. The difference lies in the fact that those functions
> are only used to implement the sysfs interface.
Yeah, maybe you are right. I thought it was just an oversight. I can send a
patch that will get orig names back if you prefer.
--
Szymon K. Janc
szymon@janc.net.pl
next prev parent reply other threads:[~2012-02-10 18:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 22:22 [PATCH v2 02/17] Staging: quickstart: Prefix remaining functions names with quickstart_ Szymon Janc
2012-02-09 1:16 ` Greg KH
2012-02-09 13:19 ` Ângelo Arrifano
2012-02-10 18:58 ` Szymon Janc [this message]
2012-02-11 1:21 ` Ângelo Arrifano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202101958.23311.szymon@janc.net.pl \
--to=szymon@janc.net.pl \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox