* [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe()
@ 2012-02-17 6:44 Dan Carpenter
2012-02-17 8:00 ` Antwort: " Jan Weitzel
2012-02-19 23:58 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2012-02-17 6:44 UTC (permalink / raw)
To: Jan Weitzel
Cc: Alexey Dobriyan, David S. Miller, Paul Gortmaker, Thomas Meyer,
Danny Kukawka, netdev, kernel-janitors
netdev->irq is unsigned, so it's never less than zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/ethernet/micrel/ks8851_mll.c
index 10d5798..b8104d9 100644
--- a/drivers/net/ethernet/micrel/ks8851_mll.c
+++ b/drivers/net/ethernet/micrel/ks8851_mll.c
@@ -1544,7 +1544,7 @@ static int __devinit ks8851_probe(struct platform_device *pdev)
netdev->irq = platform_get_irq(pdev, 0);
- if (netdev->irq < 0) {
+ if ((int)netdev->irq < 0) {
err = netdev->irq;
goto err_get_irq;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Antwort: [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe()
2012-02-17 6:44 [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe() Dan Carpenter
@ 2012-02-17 8:00 ` Jan Weitzel
2012-02-19 23:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jan Weitzel @ 2012-02-17 8:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexey Dobriyan, Danny Kukawka, David S. Miller, kernel-janitors,
netdev, Paul Gortmaker, Thomas Meyer
Dan Carpenter <dan.carpenter@oracle.com> schrieb am 17.02.2012 07:44:33:
> Von: Dan Carpenter <dan.carpenter@oracle.com>
> An: Jan Weitzel <j.weitzel@phytec.de>
> Kopie: Alexey Dobriyan <adobriyan@gmail.com>, "David S. Miller"
> <davem@davemloft.net>, Paul Gortmaker
> <paul.gortmaker@windriver.com>, Thomas Meyer <thomas@m3y3r.de>,
> Danny Kukawka <danny.kukawka@bisect.de>, netdev@vger.kernel.org,
> kernel-janitors@vger.kernel.org
> Datum: 17.02.2012 07:45
> Betreff: [patch] net/ethernet: ks8851_mll: signedness bug in
ks8851_probe()
>
> netdev->irq is unsigned, so it's never less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Tested-by: Jan Weitzel <j.weitzel@phytec.de>
> diff --git a/drivers/net/ethernet/micrel/ks8851_mll.c b/drivers/net/
> ethernet/micrel/ks8851_mll.c
> index 10d5798..b8104d9 100644
> --- a/drivers/net/ethernet/micrel/ks8851_mll.c
> +++ b/drivers/net/ethernet/micrel/ks8851_mll.c
> @@ -1544,7 +1544,7 @@ static int __devinit ks8851_probe(struct
> platform_device *pdev)
>
> netdev->irq = platform_get_irq(pdev, 0);
>
> - if (netdev->irq < 0) {
> + if ((int)netdev->irq < 0) {
> err = netdev->irq;
> goto err_get_irq;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe()
2012-02-17 6:44 [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe() Dan Carpenter
2012-02-17 8:00 ` Antwort: " Jan Weitzel
@ 2012-02-19 23:58 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2012-02-19 23:58 UTC (permalink / raw)
To: dan.carpenter
Cc: j.weitzel, adobriyan, paul.gortmaker, thomas, danny.kukawka,
netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 17 Feb 2012 09:44:33 +0300
> netdev->irq is unsigned, so it's never less than zero.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-19 23:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-17 6:44 [patch] net/ethernet: ks8851_mll: signedness bug in ks8851_probe() Dan Carpenter
2012-02-17 8:00 ` Antwort: " Jan Weitzel
2012-02-19 23:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox