[PATCH] Staging: driver usbip: Code cleanup

[PATCH] Staging: driver usbip: Code cleanup

[santosh prasad nayak]

 Code cleanup: removed commented code of old style lock initilization

Signed-off-by: Santosh <santoshprasadnayak@gmail.com>
---
 drivers/staging/usbip/stub_dev.c |    2 --
 drivers/staging/usbip/vhci_hcd.c |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/usbip/stub_dev.c b/drivers/staging/usbip/stub_dev.c
index 03420e2..fa870e3 100644
--- a/drivers/staging/usbip/stub_dev.c
+++ b/drivers/staging/usbip/stub_dev.c
@@ -297,7 +297,6 @@ static struct stub_device
*stub_device_alloc(struct usb_device *udev,
        sdev->devid             = (busnum << 16) | devnum;
        sdev->ud.side           = USBIP_STUB;
        sdev->ud.status         = SDEV_ST_AVAILABLE;
-       /* sdev->ud.lock = SPIN_LOCK_UNLOCKED; */
        spin_lock_init(&sdev->ud.lock);
        sdev->ud.tcp_socket     = NULL;

@@ -306,7 +305,6 @@ static struct stub_device
*stub_device_alloc(struct usb_device *udev,
        INIT_LIST_HEAD(&sdev->priv_free);
        INIT_LIST_HEAD(&sdev->unlink_free);
        INIT_LIST_HEAD(&sdev->unlink_tx);
-       /* sdev->priv_lock = SPIN_LOCK_UNLOCKED; */
        spin_lock_init(&sdev->priv_lock);

        init_waitqueue_head(&sdev->tx_waitq);
diff --git a/drivers/staging/usbip/vhci_hcd.c b/drivers/staging/usbip/vhci_hcd.c
index 8d96ab0..dca9bf1 100644
--- a/drivers/staging/usbip/vhci_hcd.c
+++ b/drivers/staging/usbip/vhci_hcd.c
@@ -895,14 +895,12 @@ static void vhci_device_init(struct vhci_device *vdev)

        vdev->ud.side   = USBIP_VHCI;
        vdev->ud.status = VDEV_ST_NULL;
-       /* vdev->ud.lock   = SPIN_LOCK_UNLOCKED; */
        spin_lock_init(&vdev->ud.lock);

Re: [PATCH] Staging: driver usbip: Code cleanup

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 849 bytes --]

On Sun, Feb 19, 2012 at 05:48:39PM +0530, santosh prasad nayak wrote:
>  Code cleanup: removed commented code of old style lock initilization
> 

1) The patch is line wrapped so it doesn't apply.  To test, save
your email as raw text.  `cat raw_email.txt | git am`
Read Documentation/email-clients.txt.

2) The subject could be improved.  Do a:
git log --pretty=oneline drivers/staging/usbip/stub_dev.c | head
to see the correct prefix to use.

3) Instead of "Code cleanup" choose a more descriptive name like
"Delete commented code."

4) Use your full name for the Signed-off-by line.

Please fix these and resend.

If you want, you can leave linux-usb@vger.kernel.org and
linux-kernel@vger.kernel.org off the CC list, because no one on
those lists care about trivial patches to the Staging tree.

regards,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]