From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging:android: Silence some compiler warnings
Date: Sat, 25 Feb 2012 14:33:47 +0000 [thread overview]
Message-ID: <20120225143347.GA4831@mwanda> (raw)
In-Reply-To: <1330084320-15557-1-git-send-email-ruan.zhengwang@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]
On Sat, Feb 25, 2012 at 12:03:56PM +0800, Zhengwang Ruan wrote:
> >> static int binder_debug_no_lock;
> >> -module_param_named(proc_no_lock, binder_debug_no_lock, bool, S_IWUSR | S_IRUGO);
> >> +module_param_named(proc_no_lock, binder_debug_no_lock, int, S_IWUSR | S_IRUGO);
> > Instead of doing this, it would be better to change the line before
> > and declare binder_debug_no_lock as a bool.
> >
>
> Actually, I did change the type for binder_debug_no_lock as a bool until
> I noticed binder_debug_no_lock is to be assigned value to int variables
> in the following context. I think this change may be helpful to keep
> consistence with the following context and reduce confusion from a view
> to read code.
>
The code isn't confusing... But anyway, the change affects how the
option is presented to the user, and it should be bool.
> > Use the ./scripts/get_maintainer.pl to find where to resend this
>
> Is it a common tool for community, how could I get it?
>
It's inside the kernel source tree.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-25 14:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 11:52 [PATCH] Staging:android: Silence some compiler warnings Zhengwang Ruan
2012-02-24 12:46 ` Dan Carpenter
2012-02-25 4:03 ` Zhengwang Ruan
2012-02-25 7:32 ` Julia Lawall
2012-02-25 14:33 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120225143347.GA4831@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox