From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Date: Tue, 28 Feb 2012 10:27:03 +0000 Subject: Re: [PATCH] Trace: initialize variable to clear warning Message-Id: <20120228102703.GA6090@x1.osrc.amd.com> List-Id: References: <1330420174-20537-1-git-send-email-ruan.zhengwang@gmail.com> In-Reply-To: <1330420174-20537-1-git-send-email-ruan.zhengwang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Zhengwang Ruan Cc: rostedt@goodmis.org, fweisbec@gmail.com, mingo@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Tue, Feb 28, 2012 at 05:09:34PM +0800, Zhengwang Ruan wrote: > GCC warns that 'page2' is used without being initialized previously before > being used, this is to clear it. > > Signed-off-by: Zhengwang Ruan > --- > kernel/trace/trace.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c > index a3f1bc5..47376ba 100644 > --- a/kernel/trace/trace.c > +++ b/kernel/trace/trace.c > @@ -3694,7 +3694,7 @@ tracing_mark_write(struct file *filp, const char __user *ubuf, > int nr_pages = 1; > ssize_t written; > void *page1; > - void *page2; > + void *uninitialized_var(page2); > int offset; > int size; > int len; We had this already - gcc 4.5 warns incorrectly about this, you should upgrade to 4.6: http://marc.info/?l=linux-kernel&m2083844427859 -- Regards/Gruss, Boris.