From: Dan Carpenter <dan.carpenter@oracle.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
Stanislaw Gruszka <sgruszka@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
Alan Stern <stern@rowland.harvard.edu>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] dma-debug: debugfs_create_bool() takes a u32 pointer
Date: Fri, 02 Mar 2012 12:55:02 +0000 [thread overview]
Message-ID: <20120302125502.GW1003@mwanda> (raw)
In-Reply-To: <20120302112203.GA14827@hmsreliant.think-freely.org>
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
On Fri, Mar 02, 2012 at 06:22:03AM -0500, Neil Horman wrote:
> This certainly works, but a quick search of call sites shows this isn't the only
> place someone passes a bool to debugfs_create_bool. I think the better solution
> would be to change debugfs_create_bool and its corresponding read/write methods
> to actually work with a bool type, and then clean all the call sites to pass in
> a bool properly, instead of a u32.
There is only one other call site which gets this wrong, and I sent
a fix for that today as well. But yes, you're probably right that
would be cleaner.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-03-02 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 6:58 [patch] dma-debug: debugfs_create_bool() takes a u32 pointer Dan Carpenter
2012-03-02 11:22 ` Neil Horman
2012-03-02 12:55 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302125502.GW1003@mwanda \
--to=dan.carpenter@oracle.com \
--cc=joerg.roedel@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=paul.gortmaker@windriver.com \
--cc=sgruszka@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).