From: Dan Carpenter <dan.carpenter@oracle.com>
To: walter harms <wharms@bfs.de>
Cc: Eric Wollesen <ericw@xmtp.net>,
Doug Thompson <dougthompson@xmission.com>,
list-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] edac i5000: fix pointer math in i5000_get_mc_regs()
Date: Fri, 02 Mar 2012 19:09:32 +0000 [thread overview]
Message-ID: <20120302190932.GI22598@mwanda> (raw)
In-Reply-To: <4F508C16.30900@bfs.de>
[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]
On Fri, Mar 02, 2012 at 10:00:06AM +0100, walter harms wrote:
> > diff --git a/drivers/edac/i5000_edac.c b/drivers/edac/i5000_edac.c
> > index 4dc3ac2..fcdc4ab 100644
> > --- a/drivers/edac/i5000_edac.c
> > +++ b/drivers/edac/i5000_edac.c
> > @@ -1130,7 +1130,7 @@ static void i5000_get_mc_regs(struct mem_ctl_info *mci)
> > pci_read_config_dword(pvt->system_address, AMBASE,
> > (u32 *) & pvt->ambase);
> > pci_read_config_dword(pvt->system_address, AMBASE + sizeof(u32),
> > - ((u32 *) & pvt->ambase) + sizeof(u32));
> > + (u32 *)((char *) &pvt->ambase + sizeof(u32)));
> >
> > maxdimmperch = pvt->maxdimmperch;
> > maxch = pvt->maxch;
>
> i think this is hard to understand. personally i would prefer a union or other
> more obvious solutions. my suggestion would be to get rid of this.
>
> u32 bottom,top;
> pci_read_config_dword(pvt->system_address, AMBASE,
> &bottom);
> pci_read_config_dword(pvt->system_address, AMBASE+ sizeof(u32),
> &top);
> maxdimmperch=(u64)top<<32|bottom;
>
> you can find this pattern in other parts of the kernel also.
>
Sure. I want to do this again anyway because I see I've missed some
other parts which have the same bug. I'll resend a patch later.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-02 19:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 6:54 [patch] edac i5000: fix pointer math in i5000_get_mc_regs() Dan Carpenter
2012-03-02 9:00 ` walter harms
2012-03-02 19:09 ` Dan Carpenter [this message]
2012-03-02 19:20 ` walter harms
2012-03-05 8:59 ` [patch v2] edac i5000, i5400: " Dan Carpenter
2012-03-05 9:45 ` walter harms
2012-03-05 9:52 ` Dan Carpenter
2012-03-05 10:07 ` walter harms
2012-03-06 6:38 ` [patch v3] " Dan Carpenter
2012-03-06 8:50 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120302190932.GI22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=dougthompson@xmission.com \
--cc=ericw@xmtp.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=list-edac@vger.kernel.org \
--cc=wharms@bfs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).