From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern
Date: Sat, 03 Mar 2012 07:44:46 +0000 [thread overview]
Message-ID: <20120303074446.GJ22598@mwanda> (raw)
In-Reply-To: <1330725391-9439-1-git-send-email-emilgoode@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 478 bytes --]
Looks good.
Change the subject prefix to: kprobes/x86:
get this by typing:
git log --pretty=oneline arch/x86/kernel/kprobes.c
Maybe choose a shorter subject. Such as "remove extern from
function definition."
Perhaps line wrap the commit log at 72 characters.
sparse warns:
arch/x86/kernel/kprobes.c:1489:13: warning:
function 'arch_unoptimize_kprobes' with external linkage
has definition
Resend to the people from ./scripts/get_maintainer.pl
regargs,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-03-03 7:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 21:56 [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern Emil Goode
2012-03-03 7:44 ` Dan Carpenter [this message]
2012-03-03 7:56 ` santosh prasad nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120303074446.GJ22598@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox