[PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern

[PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern

[Emil Goode]

sparse warns:
arch/x86/kernel/kprobes.c:1489:13: warning: function 'arch_unoptimize_kprobes' with external linkage has definition

This is my first patch which is why I'm sending it here first to see if I'm doing something wrong.
Any advice is greatly appreciated.

Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
 arch/x86/kernel/kprobes.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
index 7da647d..f55c28e 100644
--- a/arch/x86/kernel/kprobes.c
+++ b/arch/x86/kernel/kprobes.c
@@ -1486,8 +1486,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm,
  * Recover original instructions and breakpoints from relative jumps.
  * Caller must call with locking kprobe_mutex.
  */
-extern void arch_unoptimize_kprobes(struct list_head *oplist,
-				    struct list_head *done_list)
+void arch_unoptimize_kprobes(struct list_head *oplist,
+			     struct list_head *done_list)
 {
 	struct optimized_kprobe *op, *tmp;
 	int c = 0;
-- 
1.7.9.1

Re: [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern

[Dan Carpenter]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]


Looks good.

Change the subject prefix to: kprobes/x86:
get this by typing:
	git log --pretty=oneline arch/x86/kernel/kprobes.c


Maybe choose a shorter subject.  Such as "remove extern from
function definition."

Perhaps line wrap the commit log at 72 characters.
sparse warns:
arch/x86/kernel/kprobes.c:1489:13: warning:
	function 'arch_unoptimize_kprobes' with external linkage
	has definition

Resend to the people from ./scripts/get_maintainer.pl

regargs,
dan carpenter


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] arch: x86: kernel: kprobes: functions with definition should not be declared extern

[santosh prasad nayak]

[santosh@localhost linux-next]$ ./scripts/get_maintainer.pl --file
arch/x86/kernel/kprobes.c
Thomas Gleixner <tglx@linutronix.de> (maintainer:X86 ARCHITECTURE...)
Ingo Molnar <mingo@redhat.com> (maintainer:X86
ARCHITECTURE...,commit_signer:3/4u%)
"H. Peter Anvin" <hpa@zytor.com> (maintainer:X86 ARCHITECTURE...)
x86@kernel.org (maintainer:X86 ARCHITECTURE...)
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> (commit_signer:3/4u%)
Jiri Olsa <jolsa@redhat.com> (commit_signer:2/4P%)
Josh Stone <jistone@redhat.com> (commit_signer:2/4P%)
linux-kernel@vger.kernel.org (open list)
[santosh@localhost linux-next]$


Please send the patch to above mantainers and cc to "kernel-janitors"

Watch the video tutorial of Greg provided in the following link. Its very useful

http://www.cnx-software.com/2011/08/19/how-to-write-and-submit-a-linux-kernel-patch/


Regards
Santosh



On Sat, Mar 3, 2012 at 1:14 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> Looks good.
>
> Change the subject prefix to: kprobes/x86:
> get this by typing:
>        git log --pretty=oneline arch/x86/kernel/kprobes.c
>
>
> Maybe choose a shorter subject.  Such as "remove extern from
> function definition."
>
> Perhaps line wrap the commit log at 72 characters.
> sparse warns:
> arch/x86/kernel/kprobes.c:1489:13: warning:
>        function 'arch_unoptimize_kprobes' with external linkage
>        has definition
>
> Resend to the people from ./scripts/get_maintainer.pl
>
> regargs,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html