* [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD().
@ 2012-03-07 3:53 santosh nayak
2012-03-07 6:12 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: santosh nayak @ 2012-03-07 3:53 UTC (permalink / raw)
To: mchehab
Cc: dheitmueller, hans.verkuil, linux-media, linux-kernel,
kernel-janitors, Santosh Nayak
From: Santosh Nayak <santoshprasadnayak@gmail.com>
In CDRXD(), Negative number is assigned to unsigned variable
'state->noise_cal.tdCal2.
Members of 'SNoiseCal' should be 'signed short'.
Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
drivers/media/dvb/frontends/drxd_hard.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/media/dvb/frontends/drxd_hard.c b/drivers/media/dvb/frontends/drxd_hard.c
index 7bf39cd..f380eb4 100644
--- a/drivers/media/dvb/frontends/drxd_hard.c
+++ b/drivers/media/dvb/frontends/drxd_hard.c
@@ -101,9 +101,9 @@ struct SCfgAgc {
struct SNoiseCal {
int cpOpt;
- u16 cpNexpOfs;
- u16 tdCal2k;
- u16 tdCal8k;
+ short cpNexpOfs;
+ short tdCal2k;
+ short tdCal8k;
};
enum app_env {
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD().
2012-03-07 3:53 [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD() santosh nayak
@ 2012-03-07 6:12 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-03-07 6:12 UTC (permalink / raw)
To: santosh nayak
Cc: mchehab, dheitmueller, hans.verkuil, linux-media, linux-kernel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Wed, Mar 07, 2012 at 09:11:03AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
>
> In CDRXD(), Negative number is assigned to unsigned variable
> 'state->noise_cal.tdCal2.
>
> Members of 'SNoiseCal' should be 'signed short'.
>
In your changelogs could you please write something about how this
change will affect what the user sees. That way users know if it
fixes something they care about and they will apply your patch.
regards,
dan carpenter
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-07 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 3:53 [PATCH] [media] dvb: negative value assigned to unsigned int in CDRXD() santosh nayak
2012-03-07 6:12 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).