* [patch] atl1c: set ATL1C_WORK_EVENT_RESET bit correctly
@ 2012-03-07 10:02 Dan Carpenter
2012-03-08 8:29 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-03-07 10:02 UTC (permalink / raw)
To: Jay Cliburn
Cc: Chris Snook, David S. Miller, Ian Campbell, Eric Dumazet,
Jiri Pirko, Michał Mirosław, netdev, kernel-janitors
ATL1C_WORK_EVENT_RESET is zero so the original code here is a nop. The
intent was to set the zero bit.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
index 0f21a9b..1ef0c92 100644
--- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
+++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c
@@ -1711,7 +1711,7 @@ static irqreturn_t atl1c_intr(int irq, void *data)
"atl1c hardware error (status = 0x%x)\n",
status & ISR_ERROR);
/* reset MAC */
- adapter->work_event |= ATL1C_WORK_EVENT_RESET;
+ set_bit(ATL1C_WORK_EVENT_RESET, &adapter->work_event);
schedule_work(&adapter->common_task);
return IRQ_HANDLED;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] atl1c: set ATL1C_WORK_EVENT_RESET bit correctly
2012-03-07 10:02 [patch] atl1c: set ATL1C_WORK_EVENT_RESET bit correctly Dan Carpenter
@ 2012-03-08 8:29 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2012-03-08 8:29 UTC (permalink / raw)
To: dan.carpenter
Cc: jcliburn, chris.snook, ian.campbell, eric.dumazet, jpirko,
mirq-linux, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 7 Mar 2012 13:02:04 +0300
> ATL1C_WORK_EVENT_RESET is zero so the original code here is a nop. The
> intent was to set the zero bit.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-08 8:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-07 10:02 [patch] atl1c: set ATL1C_WORK_EVENT_RESET bit correctly Dan Carpenter
2012-03-08 8:29 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox