* [patch] qnx6fs: silence a Sparse warning
@ 2012-03-08 7:25 Dan Carpenter
2012-03-12 10:47 ` Kai Bankett
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-03-08 7:25 UTC (permalink / raw)
To: Kai Bankett; +Cc: Al Viro, linux-kernel, kernel-janitors
Add a __force to silence a sparse warning:
fs/qnx6/inode.c:88:22: warning: cast to restricted __fs32
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c
index e44012d..acf9241 100644
--- a/fs/qnx6/inode.c
+++ b/fs/qnx6/inode.c
@@ -85,7 +85,7 @@ static int qnx6_get_block(struct inode *inode, sector_t iblock,
static int qnx6_check_blockptr(__fs32 ptr)
{
- if (ptr = ~(__fs32)0) {
+ if (ptr = ~(__force __fs32)0) {
printk(KERN_ERR "qnx6: hit unused blockpointer.\n");
return 0;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] qnx6fs: silence a Sparse warning
2012-03-08 7:25 [patch] qnx6fs: silence a Sparse warning Dan Carpenter
@ 2012-03-12 10:47 ` Kai Bankett
0 siblings, 0 replies; 2+ messages in thread
From: Kai Bankett @ 2012-03-12 10:47 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Al Viro, linux-kernel, kernel-janitors
Hi Dan,
thank you very much for the provided fix.
I've successfully applied and tested it. (well, did not expect much to
happen, but just to be on the safe side)
I will include it in my next version.
Thanks,
Kai
> Add a __force to silence a sparse warning:
> fs/qnx6/inode.c:88:22: warning: cast to restricted __fs32
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/qnx6/inode.c b/fs/qnx6/inode.c
> index e44012d..acf9241 100644
> --- a/fs/qnx6/inode.c
> +++ b/fs/qnx6/inode.c
> @@ -85,7 +85,7 @@ static int qnx6_get_block(struct inode *inode, sector_t
> iblock,
>
> static int qnx6_check_blockptr(__fs32 ptr)
> {
> - if (ptr = ~(__fs32)0) {
> + if (ptr = ~(__force __fs32)0) {
> printk(KERN_ERR "qnx6: hit unused blockpointer.\n");
> return 0;
> }
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-03-12 10:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-08 7:25 [patch] qnx6fs: silence a Sparse warning Dan Carpenter
2012-03-12 10:47 ` Kai Bankett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).