Re: [patch] e1000e, igbvf: fix default message level

Jeff Kirsher
2012-03-10T09:02:15Z

[-- Attachment #1: Type: text/plain, Size: 582 bytes --]

On Sat, 2012-03-10 at 11:49 +0300, Dan Carpenter wrote:
> The intent here was to enable both NETIF_MSG_DRV and NETIF_MSG_PROBE
> messages, but in the original code only the NETIF_MSG_DRV bit was set.
>
> NETIF_MSG_DRV and NETIF_MSG_PROBE are bits 0 and 1, they are not
> supposed to be used to do a shift. I think the confusion is because
> the msg_enable can also be controlled through ethtool which passes a
> bit
> number that is used to do a bit shift.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Thanks Dan! I will add the patch to my queue.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]