From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] xHCI: use gfp flags from caller instead of GFP_ATOMIC
Date: Fri, 23 Mar 2012 16:29:57 +0000 [thread overview]
Message-ID: <20120323162957.GC5207@xanatos> (raw)
In-Reply-To: <20120323120900.GA20936@elgon.mountain>
On Fri, Mar 23, 2012 at 03:09:00PM +0300, Dan Carpenter wrote:
> We're not holding a lock here so we can use the gfp flags the caller
> specifies instead of GFP_ATOMIC. The callers use GFP_ATOMIC so this
> change doesn't affect how the kernel runs, but it's a cleanup.
Nak. We are holding a lock in all the xhci_queue* functions, so we
need GFP_ATOMIC. It's locked in a parent function, xhci_urb_enqueue().
Sarah Sharp
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index 6bd9d53..8715cc6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -2734,7 +2734,7 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags,
> urb->dev->speed = USB_SPEED_FULL)
> urb->interval /= 8;
> }
> - return xhci_queue_bulk_tx(xhci, GFP_ATOMIC, urb, slot_id, ep_index);
> + return xhci_queue_bulk_tx(xhci, mem_flags, urb, slot_id, ep_index);
> }
>
> /*
> @@ -3514,7 +3514,7 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd *xhci, gfp_t mem_flags,
> }
> ep_ring->num_trbs_free_temp = ep_ring->num_trbs_free;
>
> - return xhci_queue_isoc_tx(xhci, GFP_ATOMIC, urb, slot_id, ep_index);
> + return xhci_queue_isoc_tx(xhci, mem_flags, urb, slot_id, ep_index);
> }
>
> /**** Command Ring Operations ****/
next prev parent reply other threads:[~2012-03-23 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:09 [patch] xHCI: use gfp flags from caller instead of GFP_ATOMIC Dan Carpenter
2012-03-23 16:29 ` Sarah Sharp [this message]
2012-03-23 17:04 ` Dan Carpenter
2012-03-26 18:46 ` Sarah Sharp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120323162957.GC5207@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).