From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] xHCI: use gfp flags from caller instead of GFP_ATOMIC
Date: Mon, 26 Mar 2012 18:46:52 +0000 [thread overview]
Message-ID: <20120326184652.GA5453@xanatos> (raw)
In-Reply-To: <20120323120900.GA20936@elgon.mountain>
On Fri, Mar 23, 2012 at 08:04:51PM +0300, Dan Carpenter wrote:
> On Fri, Mar 23, 2012 at 09:29:57AM -0700, Sarah Sharp wrote:
> > On Fri, Mar 23, 2012 at 03:09:00PM +0300, Dan Carpenter wrote:
> > > We're not holding a lock here so we can use the gfp flags the caller
> > > specifies instead of GFP_ATOMIC. The callers use GFP_ATOMIC so this
> > > change doesn't affect how the kernel runs, but it's a cleanup.
> >
> > Nak. We are holding a lock in all the xhci_queue* functions, so we
> > need GFP_ATOMIC. It's locked in a parent function, xhci_urb_enqueue().
> >
>
> Sorry, bad changlog on my part. I saw that it was locked in the
> parent, but I meant that it's not taking a lock here. The parent
> specifies GFP_ATOMIC so the parent is fine.
>
> I don't think we should bother passing the GFP flags if we don't use
> them.
Ok, now I understand, and I agree. Please resend the patch with a
better change log and I'll apply it.
Sarah Sharp
prev parent reply other threads:[~2012-03-26 18:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-23 12:09 [patch] xHCI: use gfp flags from caller instead of GFP_ATOMIC Dan Carpenter
2012-03-23 16:29 ` Sarah Sharp
2012-03-23 17:04 ` Dan Carpenter
2012-03-26 18:46 ` Sarah Sharp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120326184652.GA5453@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).