From: Dan Carpenter <dan.carpenter@oracle.com>
To: Anton Vorontsov <anton.vorontsov@linaro.org>,
Felipe Contreras <felipe.contreras@gmail.com>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Felipe Balbi <balbi@ti.com>, Marek Vasut <marek.vasut@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] isp1704_charger: use after free on probe error
Date: Tue, 27 Mar 2012 20:22:13 +0000 [thread overview]
Message-ID: <20120327202212.GB9197@elgon.mountain> (raw)
We can't use "isp" after freeing it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/power/isp1704_charger.c b/drivers/power/isp1704_charger.c
index 39eb50f..e5ccd29 100644
--- a/drivers/power/isp1704_charger.c
+++ b/drivers/power/isp1704_charger.c
@@ -474,13 +474,13 @@ static int __devinit isp1704_charger_probe(struct platform_device *pdev)
fail2:
power_supply_unregister(&isp->psy);
fail1:
+ isp1704_charger_set_power(isp, 0);
usb_put_transceiver(isp->phy);
fail0:
kfree(isp);
dev_err(&pdev->dev, "failed to register isp1704 with error %d\n", ret);
- isp1704_charger_set_power(isp, 0);
return ret;
}
next reply other threads:[~2012-03-27 20:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-27 20:22 Dan Carpenter [this message]
2012-04-14 21:19 ` [patch] isp1704_charger: use after free on probe error Felipe Contreras
2012-05-06 3:03 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327202212.GB9197@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=anton.vorontsov@linaro.org \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox