From: Daniel Vetter <daniel@ffwll.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [patch] drm/i915/bios: cleanup return type of intel_parse_bios()
Date: Wed, 28 Mar 2012 11:18:21 +0000 [thread overview]
Message-ID: <20120328111821.GA27581@phenom.ffwll.local> (raw)
In-Reply-To: <20120328065942.GC9113@elgon.mountain>
On Wed, Mar 28, 2012 at 09:59:42AM +0300, Dan Carpenter wrote:
> These are unintuitive. These are type bool and return -1 casted to true
> on failure. Let's just make it return an int. The callers don't care,
> but let's change this as a cleanup.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
... or split it up into psb and i915 so I can merge it through
drm-intel-next.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
prev parent reply other threads:[~2012-03-28 11:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:59 [patch] drm/i915/bios: cleanup return type of intel_parse_bios() Dan Carpenter
2012-03-28 11:18 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120328111821.GA27581@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox