From: Dan Carpenter <dan.carpenter@oracle.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Eliot Blennerhassett <eblennerhassett@audioscience.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ALSA: asihpi - fix return type of hpios_locked_mem_alloc()
Date: Thu, 29 Mar 2012 05:56:28 +0000 [thread overview]
Message-ID: <20120329055628.GB3289@mwanda> (raw)
In-Reply-To: <s5hk424t1h9.wl%tiwai@suse.de>
I'm obviously in favour of using standard error codes where ever
possible. But when I'm writing a change like this, then I do look
at the surrounding context because there are places the use custom
error codes (SCSI is an example). In this case, I was confused
because there aren't any other error codes in this file, and also
the comment says that it should return -ENOMEM.
regards,
dan carpenter
next prev parent reply other threads:[~2012-03-29 5:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-28 6:57 [patch] ALSA: asihpi - fix return type of hpios_locked_mem_alloc() Dan Carpenter
2012-03-28 14:38 ` Takashi Iwai
2012-03-28 21:43 ` Eliot Blennerhassett
2012-03-29 5:33 ` Takashi Iwai
2012-03-29 5:56 ` Dan Carpenter [this message]
2012-03-29 20:52 ` [PATCH] ALSA: asihpi - fix return value " linux
2012-03-30 14:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120329055628.GB3289@mwanda \
--to=dan.carpenter@oracle.com \
--cc=alsa-devel@alsa-project.org \
--cc=eblennerhassett@audioscience.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox