From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 13 Apr 2012 19:28:12 +0000 Subject: [patch] NFC: remove unneeded NULL check Message-Id: <20120413192812.GE18505@elgon.mountain> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lauro Ramos Venancio Cc: Aloisio Almeida Jr , Samuel Ortiz , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org container_of() works by subtracting the offset of the member. The math can't really return a zero here. Sometimes people check it when they actually meant to check something else but in this case we can just remove the check. Signed-off-by: Dan Carpenter diff --git a/drivers/nfc/pn533.c b/drivers/nfc/pn533.c index e6ec16d..2e11da0 100644 --- a/drivers/nfc/pn533.c +++ b/drivers/nfc/pn533.c @@ -394,9 +394,6 @@ static void pn533_wq_cmd_complete(struct work_struct *work) struct pn533_frame *in_frame; int rc; - if (dev = NULL) - return; - in_frame = dev->wq_in_frame; if (dev->wq_in_error)