* [patch] wlcore: release lock on error in wl1271_op_suspend()
@ 2012-04-16 10:57 Dan Carpenter
2012-05-03 12:53 ` Luciano Coelho
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-04-16 10:57 UTC (permalink / raw)
To: Luciano Coelho
Cc: John W. Linville, Eliad Peller, Arik Nemtsov, Shahar Levi,
linux-wireless, kernel-janitors
We should release this lock before returning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wireless/ti/wlcore/main.c b/drivers/net/wireless/ti/wlcore/main.c
index 2b0f987..23fc0d2 100644
--- a/drivers/net/wireless/ti/wlcore/main.c
+++ b/drivers/net/wireless/ti/wlcore/main.c
@@ -1364,6 +1364,7 @@ static int wl1271_op_suspend(struct ieee80211_hw *hw,
wl12xx_for_each_wlvif(wl, wlvif) {
ret = wl1271_configure_suspend(wl, wlvif);
if (ret < 0) {
+ mutex_unlock(&wl->mutex);
wl1271_warning("couldn't prepare device to suspend");
return ret;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] wlcore: release lock on error in wl1271_op_suspend()
2012-04-16 10:57 [patch] wlcore: release lock on error in wl1271_op_suspend() Dan Carpenter
@ 2012-05-03 12:53 ` Luciano Coelho
0 siblings, 0 replies; 2+ messages in thread
From: Luciano Coelho @ 2012-05-03 12:53 UTC (permalink / raw)
To: Dan Carpenter
Cc: John W. Linville, Eliad Peller, Arik Nemtsov, Shahar Levi,
linux-wireless, kernel-janitors
On Mon, 2012-04-16 at 13:57 +0300, Dan Carpenter wrote:
> We should release this lock before returning.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-03 12:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-16 10:57 [patch] wlcore: release lock on error in wl1271_op_suspend() Dan Carpenter
2012-05-03 12:53 ` Luciano Coelho
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).