From: David Sterba <dave@jikos.cz>
To: Jan Schmidt <list.btrfs@jan-o-sch.net>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Chris Mason <chris.mason@oracle.com>,
Jeff Mahoney <jeffm@suse.com>,
linux-btrfs@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/2] Btrfs: double unlock bug in error handling
Date: Wed, 18 Apr 2012 11:58:42 +0000 [thread overview]
Message-ID: <20120418115842.GI20982@twin.jikos.cz> (raw)
In-Reply-To: <4F8EA5AA.2080202@jan-o-sch.net>
On Wed, Apr 18, 2012 at 01:29:46PM +0200, Jan Schmidt wrote:
> I think the correct way to fix this is:
>
> diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
> index a844204..9af261a 100644
> --- a/fs/btrfs/extent-tree.c
> +++ b/fs/btrfs/extent-tree.c
> @@ -2450,7 +2450,6 @@ again:
>
> ret = run_clustered_refs(trans, root, &cluster);
> if (ret < 0) {
> - spin_unlock(&delayed_refs->lock);
> btrfs_abort_transaction(trans, root, ret);
> return ret;
> }
That's another way to fix it, but I'd rather see the lock/unlock
balanced within a function, and in this case the extra lock does not
hurt as it's a rare codepath.
david
next prev parent reply other threads:[~2012-04-18 11:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 6:59 [patch 1/2] Btrfs: double unlock bug in error handling Dan Carpenter
2012-04-18 10:14 ` David Sterba
2012-04-18 11:29 ` Jan Schmidt
2012-04-18 11:58 ` David Sterba [this message]
2012-04-18 12:06 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120418115842.GI20982@twin.jikos.cz \
--to=dave@jikos.cz \
--cc=chris.mason@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=jeffm@suse.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=list.btrfs@jan-o-sch.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox