From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 23 Apr 2012 17:57:17 +0000
Subject: Re: [PATCH] staging: android: binder: fix some sparse warnings and long lines
Message-Id: <20120423175717.GX6498@mwanda>
List-Id: <kernel-janitors.vger.kernel.org>
References: <1335201824-17879-1-git-send-email-emilgoode@gmail.com>
In-Reply-To: <1335201824-17879-1-git-send-email-emilgoode@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: kernel-janitors@vger.kernel.org

On Mon, Apr 23, 2012 at 07:23:44PM +0200, Emil Goode wrote:
> This patch silences some sparse warnings and adds some line breaks
> to take the 80 char limit coding style rule in consideration.
> 

Don't mix long line changes and sparse changes.

You missed some fp->binder casts so there are still Sparse warnings.
Anyway, these sparse annotations should probably go into the
struct binder_node definition in the .h file instead of always
casting.  (I haven't verified.  So be careful).

Don't forget to get to run your patches through checkpatch.pl before
sending them.  (There are whitespace problems in your patch).

regards,
dan carpenter