From: Dan Carpenter <dan.carpenter@oracle.com>
To: Jean-Francois Moine <moinejf@free.fr>
Cc: Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] [media] gspca: passing wrong length parameter to reg_w()
Date: Wed, 02 May 2012 07:05:07 +0000 [thread overview]
Message-ID: <20120502070507.GO6447@mwanda> (raw)
In-Reply-To: <20120502084758.1a08823f@tele>
On Wed, May 02, 2012 at 08:47:58AM +0200, Jean-Francois Moine wrote:
> Thanks for the patch. The bug is very very old (6 years, at least -
> neither have I such a webcam).
>
My guess is that it's harmless to write a few extra garbage bits,
but it's still worth fixing as a cleanup.
> Maybe the fix could have been
>
> reg_w(gspca_dev, 0x0010, reg10, sizeof reg10);
>
> but it is OK for me.
>
> Acked-by: Jean-Francois Moine <http://moinejf.free.fr>
Thanks.
regards,
dan carpenter
prev parent reply other threads:[~2012-05-02 7:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-02 6:15 [patch] [media] gspca: passing wrong length parameter to reg_w() Dan Carpenter
2012-05-02 6:47 ` Jean-Francois Moine
2012-05-02 7:05 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120502070507.GO6447@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=moinejf@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox