From: Jonathan Nieder <jrnieder@gmail.com>
To: Emil Goode <emilgoode@gmail.com>
Cc: mchehab@infradead.org, rusty@rustcorp.com.au,
hans.verkuil@cisco.com, istvan_v@mailbox.hu,
dheitmueller@kernellabs.com, thunder.mmm@gmail.com,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] [media] cx88: Remove duplicate const
Date: Fri, 04 May 2012 09:45:38 +0000 [thread overview]
Message-ID: <20120504094538.GP6451@burratino> (raw)
In-Reply-To: <1336124017-19538-1-git-send-email-emilgoode@gmail.com>
Emil Goode wrote:
> This patch fixes the following sparse warnings
> by removing use of duplicate const.
Is this really just about quieting sparse noise?
I would find it clearer to read a more straightforward explanation
like
Remove some redundant uses of "const" detected by sparse:
but that is only a nitpick.
[...]
> --- a/drivers/media/video/cx88/cx88-alsa.c
> +++ b/drivers/media/video/cx88/cx88-alsa.c
> @@ -766,7 +766,7 @@ static struct snd_kcontrol_new snd_cx88_alc_switch = {
> * Only boards with eeprom and byte 1 at eeprom=1 have it
> */
>
> -static const struct pci_device_id const cx88_audio_pci_tbl[] __devinitdata = {
> +static const struct pci_device_id cx88_audio_pci_tbl[] __devinitdata = {
These double "const" were introduced in v2.6.37-rc1~64^2~464 (V4L/DVB:
drivers/media: Make static data tables and strings const, 2010-08-25).
The address of an array is already immutable by definition, so for
what it's worth, with or without a clarified commit message,
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
prev parent reply other threads:[~2012-05-04 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 9:33 [PATCH] [media] cx88: Remove duplicate const Emil Goode
2012-05-04 9:45 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504094538.GP6451@burratino \
--to=jrnieder@gmail.com \
--cc=dheitmueller@kernellabs.com \
--cc=emilgoode@gmail.com \
--cc=hans.verkuil@cisco.com \
--cc=istvan_v@mailbox.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=thunder.mmm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox