From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Staging: Comedi adv_pci1710 : Corrected DPRINTK formatting
Date: Fri, 04 May 2012 13:34:42 +0000 [thread overview]
Message-ID: <20120504133442.GC22134@mwanda> (raw)
In-Reply-To: <1335628246-3003-1-git-send-email-tomas.melin@iki.fi>
On Thu, May 03, 2012 at 06:27:36PM +0300, Tomas Melin wrote:
> Corrected formatting for several DPRINT messages.
>
This patch is fine, but eventually these will have to changed to:
dev_dbg(dev->class_dev,
"adv_pci1710 EDBG: BGN: pci171x_ai_cmdtest(...) err=%d ret=1\n",
err);
Or even better they can just be removed after the driver is stable.
It's not worth shifting things around too much if we're just going
to redo it later.
regards,
dan carpenter
next prev parent reply other threads:[~2012-05-04 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 15:50 [PATCH] Staging: Comedi adv_pci1710 : Corrected over 80 column warnings Tomas Melin
2012-05-03 15:27 ` [PATCH] Staging: Comedi adv_pci1710 : Corrected DPRINTK formatting Tomas Melin
2012-05-04 13:34 ` Dan Carpenter [this message]
2012-05-04 16:25 ` Tomas Melin
2012-05-04 17:08 ` Dan Carpenter
2012-05-09 20:24 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120504133442.GC22134@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox