public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: girish verma <girish.gcet@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [patch] xhci: testing sizeof xhci_doorbell_array 2 time
Date: Tue, 08 May 2012 00:26:40 +0000	[thread overview]
Message-ID: <20120508002640.GA10340@xanatos> (raw)
In-Reply-To: <CAMC5Lb4bMfqnWuvzcisGNV-uM08vHJMLt8X+mYmOp0P6RzqtrA@mail.gmail.com>

Hi Girish,

Although this is a pretty trivial change, can you please Cc the
maintainer of the driver (me, for the xHCI driver) next time?  Either
check the MAINTAINERS file, or run scripts/get_maintainer.pl.

In any case, I see no problem with this patch.  Greg's already taken it
anyway. :)

Thanks,
Sarah Sharp

On Sun, May 06, 2012 at 08:35:13PM +0530, girish verma wrote:
> Testing BUILD_BUG_ON xhci_doorbell_array structure 2 time, redundant statement
> 
> Signed-off-by: Girish Verma <girish.gcet@gmail.com>
> 
>  ---
>  drivers/usb/host/xhci.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> index 36641a7..cfcf733 100644
> --- a/drivers/usb/host/xhci.c
> +++ b/drivers/usb/host/xhci.c
> @@ -4090,7 +4090,6 @@ static int __init xhci_hcd_init(void)
>  	BUILD_BUG_ON(sizeof(struct xhci_intr_reg) != 8*32/8);
>  	/* xhci_run_regs has eight fields and embeds 128 xhci_intr_regs */
>  	BUILD_BUG_ON(sizeof(struct xhci_run_regs) != (8+8*128)*32/8);
> -	BUILD_BUG_ON(sizeof(struct xhci_doorbell_array) != 256*32/8);
>  	return 0;
>  unreg_pci:
>  	xhci_unregister_pci();
> --
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      reply	other threads:[~2012-05-08  0:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-06 15:17 [patch] xhci: testing sizeof xhci_doorbell_array 2 time girish verma
2012-05-08  0:26 ` Sarah Sharp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120508002640.GA10340@xanatos \
    --to=sarah.a.sharp@linux.intel.com \
    --cc=girish.gcet@gmail.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox