From: Dan Carpenter <dan.carpenter@oracle.com>
To: Thiago Rafael Becker <trbecker@trbecker.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, a.p.zijlstra@chello.nl,
jason.wessel@windriver.com, jan.kiszka@siemens.com,
dhowells@redhat.com
Subject: Re: [PATCH] kgbd: clear compilation warning
Date: Fri, 11 May 2012 06:23:55 +0000 [thread overview]
Message-ID: <20120511062355.GX22134@mwanda> (raw)
In-Reply-To: <1336709620-19351-1-git-send-email-trbecker@trbecker.org>
On Fri, May 11, 2012 at 01:13:40AM -0300, Thiago Rafael Becker wrote:
> In the function kgbd_arch_set_breakpoint, the variable is only used
> if DEBUG_RODATA is configured. This clears the following compilation
> warning:
>
> arch/x86/kernel/kgdb.c:749:7: warning: unused variable 'opc'
>
This doesn't work. Now there is a "warning: mixing declarations and
code" warning message for people who have CONFIG_DEBUG_RODATA
turned on.
I sent one of these yesterday where I did:
if (!config_enabled(CONFIG_DEBUG_RODATA))
return err;
But test it both ways and do a make arch/x86/kernel/kgdb.i and
make sure the code looks ok.
regards,
dan carpenter
prev parent reply other threads:[~2012-05-11 6:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 4:13 [PATCH] kgbd: clear compilation warning Thiago Rafael Becker
2012-05-11 6:23 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120511062355.GX22134@mwanda \
--to=dan.carpenter@oracle.com \
--cc=a.p.zijlstra@chello.nl \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=jan.kiszka@siemens.com \
--cc=jason.wessel@windriver.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=trbecker@trbecker.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox