From: Dan Carpenter <dan.carpenter@oracle.com>
To: Neil Brown <neilb@suse.de>
Cc: linux-raid@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [patch] md/raid10: unlock on error path in raid10_start_reshape()
Date: Thu, 17 May 2012 06:49:11 +0000 [thread overview]
Message-ID: <20120517064911.GB14660@elgon.mountain> (raw)
We need to unlock and enable IRQs before returning here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
index e8ed1d8..ba7290f 100644
--- a/drivers/md/raid10.c
+++ b/drivers/md/raid10.c
@@ -3918,6 +3918,7 @@ static int raid10_start_reshape(struct mddev *mddev)
if (mddev->reshape_backwards) {
sector_t size = raid10_size(mddev, 0, 0);
if (size < mddev->array_sectors) {
+ spin_unlock_irq(&conf->device_lock);
printk(KERN_ERR "md/raid10:%s: array size must be reduce before number of disks\n",
mdname(mddev));
return -EINVAL;
next reply other threads:[~2012-05-17 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 6:49 Dan Carpenter [this message]
2012-05-17 7:39 ` [patch] md/raid10: unlock on error path in raid10_start_reshape() NeilBrown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120517064911.GB14660@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox