From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] dlm: remove stray unlock
Date: Mon, 21 May 2012 14:35:26 +0000 [thread overview]
Message-ID: <20120521143526.GB25114@elgon.mountain> (raw)
Smatch complains that we unlock this twice. It looks like an accidental
to me.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This was added in 525f31c1f3 ("dlm: fix race between remove and lookup")
Untested.
diff --git a/fs/dlm/lock.c b/fs/dlm/lock.c
index 06063a3..1c10bf4 100644
--- a/fs/dlm/lock.c
+++ b/fs/dlm/lock.c
@@ -1570,7 +1570,6 @@ static void wait_pending_remove(struct dlm_rsb *r_new)
continue;
if (rsb_cmp(r_new, r->res_name, r->res_length))
continue;
- spin_unlock(&ls->ls_send_remove_spin);
log_debug(ls, "delay lookup %p for remove %p dir %d %s",
r_new, r, r_new->res_dir_nodeid, r_new->res_name);
next reply other threads:[~2012-05-21 14:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-21 14:35 Dan Carpenter [this message]
2012-05-21 15:39 ` [patch] dlm: remove stray unlock David Teigland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120521143526.GB25114@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox